Push down AC checks in PlayerPhysics as well

I've checked Impostor for issues that are similar to #664, and found
this one: if mods add a custom rpc on PlayerPhysics, Impostor will check
ownership of it, which isn't intentional.
This commit is contained in:
miniduikboot committed 2025-01-26 17:42:18 +01:00
1 parent d65e99fe45
commit e7b98f1842
1 file changed
+19 -6
@@ -37,17 +37,13 @@ namespace Impostor.Server.Net.Inner.Objects.Components
public override async ValueTask<bool> HandleRpcAsync(ClientPlayer sender, ClientPlayer? target, RpcCalls call, IMessageReader reader)
{
if (call != RpcCalls.BootFromVent && !await ValidateOwnership(call, sender))
{
return false;
}
switch (call)
{
case RpcCalls.EnterVent:
case RpcCalls.ExitVent:
{
if (!await ValidateCanVent(call, sender, _playerControl.PlayerInfo))
if (!await ValidateOwnership(call, sender) ||
!await ValidateCanVent(call, sender, _playerControl.PlayerInfo))
{
return false;
}
@@ -106,17 +102,34 @@ namespace Impostor.Server.Net.Inner.Objects.Components
}
case RpcCalls.ClimbLadder:
{
if (!await ValidateOwnership(call, sender))
{
return false;
}
Rpc31ClimbLadder.Deserialize(reader, out var ladderId, out var lastClimbLadderSid);
break;
}
case RpcCalls.Pet:
{
if (!await ValidateOwnership(call, sender))
{
return false;
}
Rpc49Pet.Deserialize(reader, out var position, out var petPosition);
break;
}
case RpcCalls.CancelPet:
{
if (!await ValidateOwnership(call, sender))
{
return false;
}
Rpc50CancelPet.Deserialize(reader);
break;
}