From b9f1f2fcf203f139c3bfa273bc63b256263a1e25 Mon Sep 17 00:00:00 2001 From: Az <56699741+AlchlcDvl@users.noreply.github.com> Date: Wed, 18 Nov 2026 23:42:27 -0500 Subject: [PATCH] some non-generic safety --- MiraAPI/GameOptions/OptionTypes/ModdedEnumOption.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MiraAPI/GameOptions/OptionTypes/ModdedEnumOption.cs b/MiraAPI/GameOptions/OptionTypes/ModdedEnumOption.cs index 1cb60d7c..a197221a 100644 --- a/MiraAPI/GameOptions/OptionTypes/ModdedEnumOption.cs +++ b/MiraAPI/GameOptions/OptionTypes/ModdedEnumOption.cs @@ -43,6 +43,9 @@ public class ModdedEnumOption : ModdedBaseEnumOption public ModdedEnumOption(string groupPrefix, string title, int defaultValue, Type enumType, string idPrefix, string[]? values = null, bool includeInPreset = true) : base(groupPrefix, title, defaultValue, includeInPreset) { + if (!enumType.IsEnum) + throw new ArgumentException($"The type {enumType.Name} is not an Enum.", nameof(enumType)); + idPrefix = idPrefix.Replace("%type%", enumType.Name); var rawValues = Enum.GetValues(enumType); @@ -51,6 +54,11 @@ public class ModdedEnumOption : ModdedBaseEnumOption for (var i = 0; i < rawValues.Length; i++) UnderlyingValues[i] = Convert.ToInt32(rawValues.GetValue(i), NumberFormatInfo.InvariantInfo); + if (values != null && values.Length != UnderlyingValues.Length) + { + throw new ArgumentException($"The number of custom values ({values.Length}) must exactly match the number of enum values ({UnderlyingValues.Length}) in {enumType.Name}.", nameof(values)); + } + Values = values ?? Enum.GetNames(enumType); StringNameValues = [.. Values.Select(x => MiraLocaleManager.GetOrCreateLocaleString($"{idPrefix}{x}"))];