From 9fbbfde0479faefbb7f3153b7753ad8ae466f186 Mon Sep 17 00:00:00 2001 From: Az <56699741+AlchlcDvl@users.noreply.github.com> Date: Sun, 15 Nov 2026 01:34:05 -0500 Subject: [PATCH] some more acceptable value ranges --- MiraAPI/GameOptions/OptionTypes/ModdedOption.cs | 2 +- MiraAPI/Roles/CustomRoleManager.cs | 10 ++-------- MiraAPI/Roles/ICustomRole.cs | 4 ++-- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/MiraAPI/GameOptions/OptionTypes/ModdedOption.cs b/MiraAPI/GameOptions/OptionTypes/ModdedOption.cs index 3babb611..f8d4c596 100644 --- a/MiraAPI/GameOptions/OptionTypes/ModdedOption.cs +++ b/MiraAPI/GameOptions/OptionTypes/ModdedOption.cs @@ -193,7 +193,7 @@ public abstract class ModdedOption(string groupPrefix, string title, T defaul /// public void Bind(ConfigFile config) { - config.Bind(ConfigDefinition, DefaultValue); + config.Bind(ConfigDefinition, DefaultValue, CreateDescription()); } /// diff --git a/MiraAPI/Roles/CustomRoleManager.cs b/MiraAPI/Roles/CustomRoleManager.cs index 19ce191e..18d334b4 100644 --- a/MiraAPI/Roles/CustomRoleManager.cs +++ b/MiraAPI/Roles/CustomRoleManager.cs @@ -214,14 +214,8 @@ public static class CustomRoleManager Helpers.SetInstance(typeof(CustomRoleSingleton<>), roleType, roleBehaviour); - if (customRole.Configuration.HideSettings) - { - return roleBehaviour; - } - - var config = parentMod.PluginConfig; - config.Bind(customRole.NumConfigDefinition, Mathf.Clamp(customRole.Configuration.DefaultRoleCount, 0, customRole.Configuration.MaxRoleCount)); - config.Bind(customRole.ChanceConfigDefinition, Mathf.Clamp(customRole.Configuration.DefaultChance, 0, 100)); + if (!customRole.Configuration.HideSettings) + customRole.BindConfig(parentMod.PluginConfig); return roleBehaviour; } diff --git a/MiraAPI/Roles/ICustomRole.cs b/MiraAPI/Roles/ICustomRole.cs index ba5c896a..bbed64b2 100644 --- a/MiraAPI/Roles/ICustomRole.cs +++ b/MiraAPI/Roles/ICustomRole.cs @@ -189,8 +189,8 @@ public interface ICustomRole : IOptionable /// The ConfigFile to bind the options to. void BindConfig(ConfigFile config) { - config.Bind(NumConfigDefinition, Configuration.DefaultRoleCount); - config.Bind(ChanceConfigDefinition, Configuration.DefaultChance); + config.Bind(NumConfigDefinition, Configuration.DefaultRoleCount, new ConfigDescription(string.Empty, new AcceptableValueRange(0, Configuration.MaxRoleCount))); + config.Bind(ChanceConfigDefinition, Configuration.DefaultChance, new ConfigDescription(string.Empty, new AcceptableValueRange(0, 100))); } ///