From 6b2bdc11f9e72d1bfbe450d3b0c44d8a7036741d Mon Sep 17 00:00:00 2001 From: Az <56699741+AlchlcDvl@users.noreply.github.com> Date: Fri, 13 Nov 2026 02:43:45 -0500 Subject: [PATCH] fix small issues + remove deprecated code --- MiraAPI/GameOptions/AbstractOptionGroup.cs | 9 +-------- .../OptionList/ModdedPlayerOptionListAttribute.cs | 2 +- MiraAPI/GameOptions/IModdedOption.cs | 2 +- MiraAPI/GameOptions/OptionTypes/ModdedNumberOption.cs | 2 +- MiraAPI/GameOptions/OptionTypes/ModdedPlayerOption.cs | 2 +- 5 files changed, 5 insertions(+), 12 deletions(-) diff --git a/MiraAPI/GameOptions/AbstractOptionGroup.cs b/MiraAPI/GameOptions/AbstractOptionGroup.cs index c0056e60..a8e74250 100644 --- a/MiraAPI/GameOptions/AbstractOptionGroup.cs +++ b/MiraAPI/GameOptions/AbstractOptionGroup.cs @@ -39,7 +39,7 @@ public abstract class AbstractOptionGroup public abstract string GroupName { get; } /// - /// Gets the ID prefix used for options in this group (e.g., "Options.Teleporter"). + /// Gets the ID prefix used for options in this group (e.g., "Options.Teleporter."). /// public virtual string GroupPrefix => string.Empty; @@ -54,13 +54,6 @@ public abstract class AbstractOptionGroup /// public virtual Type? OptionableType => null; - /// - /// Gets a value indicating whether the group should be shown in the modifiers menu. - /// - // Completed: make this not a boolean - [Obsolete("Use ParentMenu instead. This will be removed in a future version.", true)] - public virtual bool ShowInModifiersMenu => false; - /// /// Gets a value indicating which menu the group is in. /// diff --git a/MiraAPI/GameOptions/Attributes/OptionList/ModdedPlayerOptionListAttribute.cs b/MiraAPI/GameOptions/Attributes/OptionList/ModdedPlayerOptionListAttribute.cs index 815a2834..986e7b5e 100644 --- a/MiraAPI/GameOptions/Attributes/OptionList/ModdedPlayerOptionListAttribute.cs +++ b/MiraAPI/GameOptions/Attributes/OptionList/ModdedPlayerOptionListAttribute.cs @@ -25,7 +25,7 @@ public class ModdedPlayerOptionListAttribute(string? title, bool allowNone = tru internal override IBaseModdedOptionList CreateOptionList(IList list, PropertyInfo property, AbstractOptionGroup group) { - return new ModdedOptionList(list.Count, idx => new(GetFormattedTitle(idx, property), allowNone)); + return new ModdedOptionList(list.Count, idx => new(group.GroupPrefix, GetFormattedTitle(idx, property), allowNone)); } /// diff --git a/MiraAPI/GameOptions/IModdedOption.cs b/MiraAPI/GameOptions/IModdedOption.cs index 44932824..84650541 100644 --- a/MiraAPI/GameOptions/IModdedOption.cs +++ b/MiraAPI/GameOptions/IModdedOption.cs @@ -101,7 +101,7 @@ public interface IModdedOption OptionBehaviour CreateOption(ToggleOption toggleOpt, NumberOption numberOpt, StringOption stringOpt, PlayerOption playerOpt, Transform container); /// - /// Gets the translated display value of the toggle option. + /// Gets the translated display value of the option. /// /// The display value. string GetDisplayValue(); diff --git a/MiraAPI/GameOptions/OptionTypes/ModdedNumberOption.cs b/MiraAPI/GameOptions/OptionTypes/ModdedNumberOption.cs index 428d96cf..f5d36774 100644 --- a/MiraAPI/GameOptions/OptionTypes/ModdedNumberOption.cs +++ b/MiraAPI/GameOptions/OptionTypes/ModdedNumberOption.cs @@ -301,6 +301,6 @@ public class ModdedNumberOption : ModdedOption /// Integer value. public static implicit operator int(ModdedNumberOption option) { - return (int)MathF.Round(option.Value); + return (int)MathF.Round(option.Value, MidpointRounding.AwayFromZero); } } diff --git a/MiraAPI/GameOptions/OptionTypes/ModdedPlayerOption.cs b/MiraAPI/GameOptions/OptionTypes/ModdedPlayerOption.cs index 5e7ef15d..455d9b54 100644 --- a/MiraAPI/GameOptions/OptionTypes/ModdedPlayerOption.cs +++ b/MiraAPI/GameOptions/OptionTypes/ModdedPlayerOption.cs @@ -85,7 +85,7 @@ public class ModdedPlayerOption : ModdedOption playerOption.SetValueText(); playerOption.AdjustButtonsActiveState(); - playerOpt.gameObject.AddComponent().PlayerOption = this; + playerOption.gameObject.AddComponent().PlayerOption = this; OptionBehaviour = playerOption;