From 0596278b7808b5fa8bc181088b2c8a7f333edd48 Mon Sep 17 00:00:00 2001 From: neilmjain <69025896+neilmjain@users.noreply.github.com> Date: Thu, 22 Oct 2026 19:26:07 -0400 Subject: [PATCH] move scroller bounds to be set in Open() --- MiraAPI/LocalSettings/LocalSettingsTab.cs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MiraAPI/LocalSettings/LocalSettingsTab.cs b/MiraAPI/LocalSettings/LocalSettingsTab.cs index 0b8557c6..310c2c08 100644 --- a/MiraAPI/LocalSettings/LocalSettingsTab.cs +++ b/MiraAPI/LocalSettings/LocalSettingsTab.cs @@ -74,6 +74,7 @@ public abstract class LocalSettingsTab(ConfigFile config) protected int TabIndex => LocalSettingsManager.Tabs.IndexOf(this) + 10; private Scroller? Scroller { get; set; } + private float MaxScroll { get; set; } /// /// Invoked when an option value is changed. @@ -104,6 +105,12 @@ public abstract class LocalSettingsTab(ConfigFile config) label.Key.text = $"{label.Value.Translate()}"; } + + if (Scroller != null) + { + Scroller.SetBounds(new FloatRange(0, MaxScroll), new FloatRange(0, 0)); + Scroller.ScrollToTop(); + } } /// @@ -222,9 +229,7 @@ public abstract class LocalSettingsTab(ConfigFile config) const float extraPadding = 0.25f; var itemRange = (Settings.Count + Buttons.Count) * 0.5f - visibleHeight; var offsetRange = contentOffset - visibleHeight + extraPadding; - var maxScroll = Mathf.Max(0f, itemRange, offsetRange); - Scroller.SetBounds(new FloatRange(0, maxScroll), new FloatRange(0, 0)); - Scroller.ScrollToTop(); + MaxScroll = Mathf.Max(0f, itemRange, offsetRange); return tab; }